[PATCH] D14382: [ELF2] - Basic implementation of -r/--relocatable

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/OutputSections.cpp:751
@@ +750,3 @@
+template <class ELFT>
+StaticRelocSection<ELFT>::StaticRelocSection(StringRef Name, uint32_t Type,
+                                             uintX_t Flags, bool IsRela)
----------------
grimar wrote:
> rafael wrote:
> > This is remarkably similar to OutputSeciton. Can you use that? 
> Sorry, I am not sure what do you mean here. If you mean I can inhirit from OutputSeciton then I was already asked to not do that. That was initial plan in earlier revision of this patch.
> If you meant something else, could you please give more details about that ?
I also can't just use OutputSection instead of StaticRelocSection because of additional logic involved.


http://reviews.llvm.org/D14382