[PATCH] D17333: [lld] [AArch64] Initial TLSDESC relocations support

[Rafael Ávila de Espíndola via llvm-commits]

rafael added inline comments.

================
Comment at: test/ELF/aarch64-tls-tlsdesc.s:14
@@ +13,3 @@
+#RELOC-NEXT: {{.*}} R_AARCH64_TLSDESC t1
+
+#CHECK:  1000:  fd 7b bf a9     stp     x29, x30, [sp, #-16]!
----------------
Please add

#RELOC-NEXT: }
#RELOC-NEXT: ]

to make sure we are looking at all the relocations.

================
Comment at: test/ELF/aarch64-tls-tlsdesc.s:18
@@ +17,3 @@
+#CHECK:  1008:  00 00 00 b0     adrp    x0, #4096
+#CHECK:  100c:  01 48 40 f9     ldr     x1, [x0, #144]
+#CHECK:  1010:  00 40 02 91     add     x0, x0, #144
----------------
Please add the expression that computes 144.


Repository:
  rL LLVM

http://reviews.llvm.org/D17333