[PATCH] D17388: Rename embedded bitcode section in MachO
Davide Italiano via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 19 12:43:58 PST 2016
davide added a subscriber: davide.
================
Comment at: lib/Object/FunctionIndexObjectFile.cpp:42
@@ -40,3 +41,3 @@
return EC;
- if (SecName == ".llvmbc") {
+ if (SecName == BitcodeSectName) {
StringRef SecContents;
----------------
You can just inline the call here (also true in the other case), as there's only one use of this variable.
================
Comment at: lib/Object/ObjectFile.cpp:119
@@ +118,3 @@
+const char* ObjectFile::getSectionNameForBitcode(const ObjectFile &Obj) {
+ if (Obj.isMachO())
+ return "__bitcode";
----------------
this can be spelled in a more compact form.
return (Obj.isMachO()) ? "__bitcode" : ".llvmbc";
http://reviews.llvm.org/D17388
More information about the llvm-commits
mailing list