[PATCH] D17351: [zorg] Addition of extraLitArgs variable to ClangAndLLDBuilder.py

[Galina via llvm-commits]

gkistanova added inline comments.

================
Comment at: zorg/buildbot/builders/ClangAndLLDBuilder.py:104
@@ -102,2 +103,3 @@
     if extraCompilerOptions:
+        assert extraCompilerOptions not in ["-DLLVM_LIT_ARGS="], "%s is not allowed to be defined here.  PLease use extraLitArgs to pass Lit arguments instead."
         options += extraCompilerOptions
----------------
Did you mean checking extraCmakeOptions instead? extraCompilerOptions are C/C++ flags...

However, this assert would not work as you think it is.
You want something similar to this:

```
  assert any(a.startswith('-DLLVM_LIT_ARGS=') for a in extraCmakeOptions, "Please use extraLitArgs for LIT arguments instead of defining them in extraCmakeOptions."
```



http://reviews.llvm.org/D17351