[PATCH] D17442: [LPM] Remove the last worrisome split in the primary loop pass pipeline, allowing LICM and friends to always run over the outer loop after unrolling has a chance to remove the inner loop.
Mehdi AMINI via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 19 08:40:47 PST 2016
joker.eph added inline comments.
================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:248
@@ +247,3 @@
+ // entire pipeline on outer loops after the pipeline simplifies inner loops.
+ // Without this, significant phase ordering problems can develop.
+
----------------
I'd add a reference to the PR between parentheses at the end, because "bad things can happen" is typically the kind of comments that will stay there forever with no-one remembering what it refers to.
http://reviews.llvm.org/D17442
More information about the llvm-commits
mailing list