[PATCH] D17321: DIEData, DIEWriter: introduce and begin migration.

[Adrian Prantl via llvm-commits]

aprantl added a comment.

I'd be very interested in the size impact. Do you have access to a Darwin machine? Could you build something large and then run llvm-dsymutil with and without the patch on it and compare the differences?


================
Comment at: include/llvm/CodeGen/DIEData.h:64
@@ +63,3 @@
+public:
+  /// \brief Get the bytes that need to be emitted to the DWARF abbreviation
+  /// section.
----------------
Certainly the most important part of the review :-)
We enable autobrief in Doxygen now. In most situations \brief is redundant now.

================
Comment at: test/DebugInfo/X86/linkage-name.ll:7
@@ -5,1 +6,3 @@
+
+; CHECK: DW_TAG_subprogram [{{.*}}] *
 ; CHECK-NOT: DW_AT_{{(MIPS_)?}}linkage_name
----------------
If we're not checking the FORMs matching them just adds visual noise to the test. I would just delete everything after the TAG.
(this applies to all testcases)


http://reviews.llvm.org/D17321