[PATCH] D17290: [ELF] - Teach input section wildcard patterns to recognize '?' meta character.

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/LinkerScript.cpp:66
@@ -61,3 +65,3 @@
   for (;;) {
-    if (S.empty())
+    if (W.empty())
       return T.empty();
----------------
rafael wrote:
> Why rename S to W in the same commit?
We often rename the variables during common patches. See nothing ubnormal here. But reverted it back, if you think it is better to do separatelly.

================
Comment at: test/ELF/wildcards.s:1
@@ +1,2 @@
+# REQUIRES: x86
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t
----------------
ruiu wrote:
> If you create a new file, please move the existing test for '*' in linkerscript-sections.s to this file.
I can't do that. Those test uses those file source code.
I removed test from linkerscript-sections.s and added one additional for * here.


http://reviews.llvm.org/D17290