[PATCH] D17207: [ADT] Fix PointerEmbeddedInt when the underlying type is uintptr_t.

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 18 12:49:58 PST 2016


chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: include/llvm/ADT/PointerEmbeddedInt.h:48-50
@@ -44,3 +47,5 @@
 
+  static constexpr const struct RawValueTag {} RawValue = {};
+
   friend class PointerLikeTypeTraits<PointerEmbeddedInt>;
 
----------------
Watch for buildbot complaints about this constexpr. If necessary, I'd rather the good calling convention and a nonce value with a definition in the .cpp file than using enums. But hopefully this just works. =]


http://reviews.llvm.org/D17207





More information about the llvm-commits mailing list