[PATCH] D17265: [lld] [ELF/AArch64] Fix R_AARCH64_ABS64 in Shared mode

Adhemerval Zanella via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 18 05:35:20 PST 2016


zatrazz added inline comments.

================
Comment at: ELF/Target.cpp:1067-1072
@@ -1059,1 +1066,8 @@
 
+uint64_t PPC64TargetInfo::getDynRelativeAddend(unsigned Type,
+                                               uint64_t Addend) const {
+  if (Type == R_PPC64_TOC)
+    return getPPC64TocBase() + Addend;
+  return Addend;
+}
+
----------------
ruiu wrote:
> I skimmed through the relocation handling of PPC, but I couldn't find the location for this particular code. Can you describe it for me? (And adding a comment would be appreciated.)
I have added it on development phase, but seems ppc already handle that in elf2::getLocalRelTarget. I will remove it.


Repository:
  rL LLVM

http://reviews.llvm.org/D17265





More information about the llvm-commits mailing list