[PATCH] D17137: [mips][microMIPS] Add CodeGen support for DIV, MOD, DIVU, MODU, DDIV, DMOD, DDIVU and DMODU instructions

[Simon Dardis via llvm-commits]

sdardis added a subscriber: sdardis.
sdardis added a reviewer: sdardis.
sdardis added a comment.

Some nits. You're checking for nops in some cases. Checking for these in my view renders these tests fragile as microMIPS has the 'jrc' instruction which does not have a delay slot and hence a nop would not be required.


================
Comment at: lib/Target/Mips/MipsISelLowering.cpp:912
@@ -911,3 +911,3 @@
                                               const TargetInstrInfo &TII,
-                                              bool Is64Bit) {
+                                              bool Is64Bit, bool isMicroMips) {
   if (NoZeroDivCheck)
----------------
Nit: should be IsMicromips.


http://reviews.llvm.org/D17137