[PATCH] D17354: Reformat NVPTXInstrInfo.td, and add additional comments.
Justin Lebar via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 17 16:19:29 PST 2016
jlebar added a comment.
In http://reviews.llvm.org/D17354#355191, @jholewinski wrote:
> What is the motivation for this?
After finding the bug in http://reviews.llvm.org/D17315, I'm trawling through the tablegen files looking for other issues. I was going to have to carefully read the whole thing anyway, and figure I'm going to be more successful finding bugs if the code is consistently-formatted.
> Is it reformatted with a tool?
http://www.kinesis-ergo.com/shop/advantage-for-pc-mac/ :-p
> I'm not fundamentally opposed to such a change; I just want to understand the rationale since it touches a *lot* of code.
If it helps, here's a diff that ignores all whitespace, including newlines.
$ git diff --word-diff-regex=[^[:space:]] 7126dbe9c^..7126dbe9c | gist
https://gist.github.com/de3b01211b52b6162380
If you run this in your own terminal (fetch this branch: https://github.com/jlebar/llvm/tree/nvvm-reformat) it'll be all nice and color-coded.
http://reviews.llvm.org/D17354
More information about the llvm-commits
mailing list