[PATCH] D17320: Don't tail-duplicate blocks that contain convergent instructions.

Justin Lebar via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 17 15:56:00 PST 2016


jlebar added inline comments.

================
Comment at: lib/CodeGen/TailDuplication.cpp:593
@@ +592,3 @@
+    // new control dependencies, which is what we're going to do here.
+    // TODO: Test, and test that calls to convergent functions are convergent,
+    // and test that indirect calls are always convergent.
----------------
iteratee wrote:
> I think one of your TODOs is done.
Yeah, thanks.  I nuked this and moved the one about convergent MIs into MachineInstr::isConvergent, where it belongs.


http://reviews.llvm.org/D17320





More information about the llvm-commits mailing list