[PATCH] D17327: [WebAssembly] Disable register stackification and coloring when not optimizing

Dan Gohman via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 17 15:18:28 PST 2016


sunfish accepted this revision.
sunfish added a comment.
This revision is now accepted and ready to land.

I expect eventually we'll want to do *some* coloring and stackification at -O0, though it's a good point that stackification can reorder things in ways that make debugging harder. Perhaps at -O0 stackification can just stackify things that don't require reordering. In any case, we can work that out later, and this patch lgtm for now.


================
Comment at: lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTargetDesc.cpp:47
@@ +46,3 @@
+                                          CodeGenOpt::Level OL) {
+  CodeModel::Model M = CM == CodeModel::Default ? CodeModel::Large : CM;
+  if (M != CodeModel::Large)
----------------
Looks good. We should handle DefaultJIT as Large too. Of course, we don't have full JIT support yet, but that's no reason for this code not to be ready for when we do :-).


http://reviews.llvm.org/D17327





More information about the llvm-commits mailing list