[PATCH] D17320: Don't tail-duplicate blocks that contain convergent instructions.

[Kyle Butt via llvm-commits]

iteratee added a comment.

Small comment nit, but other than that it looks good.

For your todo, I'd prefer to see that logic inside of MI.isConvergent() rather than scattered.


================
Comment at: lib/CodeGen/TailDuplication.cpp:593
@@ +592,3 @@
+    // new control dependencies, which is what we're going to do here.
+    // TODO: Test, and test that calls to convergent functions are convergent,
+    // and test that indirect calls are always convergent.
----------------
I think one of your TODOs is done.


http://reviews.llvm.org/D17320