[PATCH] D17326: Fix load alignement when unpacking aggregates structs

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 17 08:45:17 PST 2016


majnemer requested changes to this revision.
majnemer added a comment.
This revision now requires changes to proceed.

Actually, some last minute questions came up...


================
Comment at: lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp:548
@@ +547,3 @@
+    if (!Align)
+      Align = SL->getAlignment();
+
----------------
I think it'd be more obvious if you used `DL.getABITypeAlignment(ST)` here seeing as how the langref defines the load's alignment using the language: A value of 0 or an omitted align argument means that the operation has the ABI alignment for the target.


http://reviews.llvm.org/D17326





More information about the llvm-commits mailing list