[PATCH] D17329: [AA] Hoist the logic to reformulate various AA queries in terms of other parts of the AA interface out of the base class of every single AA result object.

[Sanjoy Das via llvm-commits]

sanjoy added a comment.

Some "peephole" review comments inline:


================
Comment at: include/llvm/Analysis/AliasAnalysis.h:757
@@ -755,5 +756,3 @@
 
-  const TargetLibraryInfo &TLI;
-
-  explicit AAResultBase(const TargetLibraryInfo &TLI) : TLI(TLI) {}
+  explicit AAResultBase() {}
 
----------------
Is `explicit` needed here?

================
Comment at: include/llvm/Analysis/CFLAliasAnalysis.h:35
@@ -34,3 +34,3 @@
 public:
-  explicit CFLAAResult(const TargetLibraryInfo &TLI);
+  explicit CFLAAResult();
   CFLAAResult(CFLAAResult &&Arg);
----------------
Is `explicit` needed?

================
Comment at: include/llvm/Analysis/ScopedNoAliasAA.h:30
@@ -29,4 +29,3 @@
 public:
-  explicit ScopedNoAliasAAResult(const TargetLibraryInfo &TLI)
-      : AAResultBase(TLI) {}
+  explicit ScopedNoAliasAAResult() : AAResultBase() {}
   ScopedNoAliasAAResult(ScopedNoAliasAAResult &&Arg)
----------------
Ditto about `explicit`


http://reviews.llvm.org/D17329