[llvm] r260880 - Reverted r260879 as it caused test failures in lld.

[Scott Egerton via llvm-commits]

Great, I shall commit this now then.

-----Original Message-----
From: Simon Atanasyan [mailto:simon at atanasyan.com] 
Sent: 16 February 2016 17:14
To: Scott Egerton
Cc: LLVM Commits
Subject: Re: [llvm] r260880 - Reverted r260879 as it caused test failures in lld.

I think we can fix all issues related to this call by a single commit.

On Tue, Feb 16, 2016 at 3:49 PM, Scott Egerton <Scott.Egerton at imgtec.com> wrote:
> Hi Simon,
>
> Thanks for pointing this out, I hadn't noticed. Would you mind if I committed this change in the same patch?
>
> Yes I did mean got16-micro.test. Thank you for offering to change this for me.
>
>
> Scott Egerton
>
> -----Original Message-----
> From: Simon Atanasyan [mailto:simon at atanasyan.com]
> Sent: 15 February 2016 14:04
> To: Scott Egerton
> Cc: LLVM Commits
> Subject: Re: [llvm] r260880 - Reverted r260879 as it caused test failures in lld.
>
> Hi Scott,
>
> On Mon, Feb 15, 2016 at 1:04 PM, Scott Egerton via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>> =====================================================================
>> =
>> ========
>> --- llvm/trunk/lib/Target/Mips/MCTargetDesc/MipsTargetStreamer.cpp
>> (original)
>> +++ llvm/trunk/lib/Target/Mips/MCTargetDesc/MipsTargetStreamer.cpp 
>> +++ Mon Feb 15 04:04:38 2016
>> @@ -611,7 +611,7 @@ void MipsTargetELFStreamer::emitDirectiv
>>    MCStreamer &OS = getStreamer();
>>
>>    MCSectionELF *Sec = Context.getELFSection(".pdr", ELF::SHT_PROGBITS,
>> -                                            ELF::SHT_REL);
>> +                                            ELF::SHF_ALLOC | 
>> + ELF::SHT_REL);
>
> Both initial and new variants of this code look strange. The third argument of getELFSection is ELF section flags. But ELF::SHT_REL is a section type. I think the correct one should be as follow:
>
> MCSectionELF *Sec = Context.getELFSection(".pdr", ELF::SHT_PROGBITS, 
> 0);
>
> As far as I understand by lld failure you mean got16-micro.test.
> Right? Fill free to commit the changes. I will change this test case after that.
>
> --
> Simon Atanasyan



--
Simon Atanasyan