[PATCH] D17317: [attrs] Handle convergent CallSites.

[Justin Lebar via llvm-commits]

jlebar added inline comments.

================
Comment at: lib/Transforms/InstCombine/InstCombineCalls.cpp:2039-2042
@@ +2038,6 @@
+    if (CS.isConvergent() && !CalleeF->isConvergent()) {
+      DEBUG(dbgs() << "Removing convergent attr from instr "
+                   << CS.getInstruction() << "\n");
+      CS.setNotConvergent();
+      Changed = true;
+    }
----------------
chandlerc wrote:
> It's not clear that it is correct to fall through here... Usually these things go back onto a worklist and get visited again anyways. Is there a reason you chose this particular pattern?
No particular reason; I was following the Indices.empty() branch above, which seems to be doing something similar.  I changed it as suggested.


http://reviews.llvm.org/D17317