[PATCH] D16756: Added SKL and CNL processors and features to Clang
David Kreitzer via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 16 20:31:29 PST 2016
DavidKreitzer added a comment.
I would avoid adding any new pre-defined macros until we get agreement from gcc and/or icc on the exact spellings. For all the new feature-based macros that you are adding, e.g. __MPX__, __MOVBE__, etc., do we have consensus on the spellings?
Also, why did you remove the tests for -march=skylake and -march=cannonlake from predefined-arch-macros.c? I think you want to keep those.
http://reviews.llvm.org/D16756
More information about the llvm-commits
mailing list