[PATCH] D16597: Query the StringMap only once when creating MDString (NFC)

Mehdi Amini via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 16 18:23:58 PST 2016


Oh, this was sitting in my list of "accepted revision" on phabricator and I was trying to empty my queue. Since Phabricator has this annoying limitation that it does not record non-top-post answer, it didn't keep the past discussion, so I today I only saw Pete's comment that said OK. 

Reverted in r261055. Thanks for notifying me!

-- 
Mehdi

> On Feb 16, 2016, at 6:16 PM, David Blaikie <dblaikie at gmail.com> wrote:
> 
> It sounded like Duncan had some pretty strong feelings against this - should it have really been committed?
> 
> On Tue, Feb 16, 2016 at 3:10 PM, Mehdi AMINI via llvm-commits <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
> joker.eph closed this revision.
> joker.eph added a comment.
> 
> r261030
> 
> 
> http://reviews.llvm.org/D16597 <http://reviews.llvm.org/D16597>
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits>
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160216/f766149a/attachment.html>


More information about the llvm-commits mailing list