[llvm] r261036 - Fix MSVC bot: apparently visual studio does not like explicitly defaulted move ctor

Mehdi Amini via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 16 16:11:59 PST 2016


Author: mehdi_amini
Date: Tue Feb 16 18:11:59 2016
New Revision: 261036

URL: http://llvm.org/viewvc/llvm-project?rev=261036&view=rev
Log:
Fix MSVC bot: apparently visual studio does not like explicitly defaulted move ctor

From: Mehdi Amini <mehdi.amini at apple.com>

Modified:
    llvm/trunk/include/llvm/IR/Metadata.h

Modified: llvm/trunk/include/llvm/IR/Metadata.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/Metadata.h?rev=261036&r1=261035&r2=261036&view=diff
==============================================================================
--- llvm/trunk/include/llvm/IR/Metadata.h (original)
+++ llvm/trunk/include/llvm/IR/Metadata.h Tue Feb 16 18:11:59 2016
@@ -594,7 +594,9 @@ class MDString : public Metadata {
   MDString() : Metadata(MDStringKind, Uniqued), Entry(nullptr) {}
 
 public:
-  MDString(MDString &&R) = default;
+  // This is a "default" move ctor, MSVC does not support "= default" here
+  MDString(MDString &&R)
+      : Metadata(MDStringKind, Uniqued), Entry(std::move(R.Entry)) {}
   static MDString *get(LLVMContext &Context, StringRef Str);
   static MDString *get(LLVMContext &Context, const char *Str) {
     return get(Context, Str ? StringRef(Str) : StringRef());




More information about the llvm-commits mailing list