[PATCH] D17294: Fix for PR 26500

Nemanja Ivanovic via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 16 09:35:13 PST 2016


nemanjai added a comment.

I was thinking of adding a test case from the PR (reduced in a trivial way but still 915 lines of IR). However, I think the key things to test here are:

1. No change in behaviour for non-shrink-rapped functions
2. Shrink-wrapped functions only change by potentially using a register other than R12 to spill CR
3. The selected register isn't live in the basic block

Number 1. is accomplished by the fact that other test cases did not have to change. Numbers 2. and 3. cannot really be tested reliably in the IR test case.
The only thing I see as a possibility is that I add a test case to projects/test-suite that ensures there's no crash with this fix (i.e. build the program Anton posted in the PR and run it).


Repository:
  rL LLVM

http://reviews.llvm.org/D17294





More information about the llvm-commits mailing list