[PATCH] D17241: [Polly] [Refactor] Move isl_ctx into Scop.

Michael Kruse via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 16 00:06:09 PST 2016


Meinersbur added a subscriber: Meinersbur.
Meinersbur added a comment.

We don't modify the source in External/isl. For any change there, we have to ask Sven Verdoolaege to include it into the mainline isl. In the context of isl only this makes less sense. One would want to have a proper memory management instead of disabling the memory leak detection feature.

Because of missing alternatives, I'd vote for the shared_ptr solution.


================
Comment at: include/polly/ScopInfo.h:1282
@@ -1276,2 +1281,3 @@
+  /// delete the last object that creates isl objects with the context.
   isl_ctx *IslCtx;
 
----------------
The comment still mentions shared_ptr.


http://reviews.llvm.org/D17241





More information about the llvm-commits mailing list