[PATCH] D17282: Kill LLVMAddTargetData

Amaury SECHET via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 15 16:26:29 PST 2016


This revision was automatically updated to reflect the committed changes.
Closed by commit rL260919: Kill LLVMAddTargetData (authored by deadalnix).

Changed prior to commit:
  http://reviews.llvm.org/D17282?vs=48025&id=48036#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D17282

Files:
  llvm/trunk/bindings/go/llvm/executionengine_test.go
  llvm/trunk/bindings/go/llvm/target.go
  llvm/trunk/docs/ReleaseNotes.rst
  llvm/trunk/include/llvm-c/Target.h
  llvm/trunk/lib/Target/Target.cpp
  llvm/trunk/unittests/ExecutionEngine/MCJIT/MCJITCAPITest.cpp

Index: llvm/trunk/include/llvm-c/Target.h
===================================================================
--- llvm/trunk/include/llvm-c/Target.h
+++ llvm/trunk/include/llvm-c/Target.h
@@ -187,11 +187,6 @@
     See the constructor llvm::DataLayout::DataLayout. */
 LLVMTargetDataRef LLVMCreateTargetData(const char *StringRep);
 
-/** Adds target data information to a pass manager. This does not take ownership
-    of the target data.
-    See the method llvm::PassManagerBase::add. */
-void LLVMAddTargetData(LLVMTargetDataRef TD, LLVMPassManagerRef PM);
-
 /** Adds target library information to a pass manager. This does not take
     ownership of the target library info.
     See the method llvm::PassManagerBase::add. */
Index: llvm/trunk/lib/Target/Target.cpp
===================================================================
--- llvm/trunk/lib/Target/Target.cpp
+++ llvm/trunk/lib/Target/Target.cpp
@@ -46,9 +46,6 @@
   return wrap(new DataLayout(StringRep));
 }
 
-void LLVMAddTargetData(LLVMTargetDataRef TD, LLVMPassManagerRef PM) {
-}
-
 void LLVMAddTargetLibraryInfo(LLVMTargetLibraryInfoRef TLI,
                               LLVMPassManagerRef PM) {
   unwrap(PM)->add(new TargetLibraryInfoWrapperPass(*unwrap(TLI)));
Index: llvm/trunk/unittests/ExecutionEngine/MCJIT/MCJITCAPITest.cpp
===================================================================
--- llvm/trunk/unittests/ExecutionEngine/MCJIT/MCJITCAPITest.cpp
+++ llvm/trunk/unittests/ExecutionEngine/MCJIT/MCJITCAPITest.cpp
@@ -285,7 +285,6 @@
   
   void buildAndRunPasses() {
     LLVMPassManagerRef pass = LLVMCreatePassManager();
-    LLVMAddTargetData(LLVMGetExecutionEngineTargetData(Engine), pass);
     LLVMAddConstantPropagationPass(pass);
     LLVMAddInstructionCombiningPass(pass);
     LLVMRunPassManager(pass, Module);
@@ -304,8 +303,6 @@
     LLVMPassManagerRef modulePasses =
       LLVMCreatePassManager();
     
-    LLVMAddTargetData(LLVMGetExecutionEngineTargetData(Engine), modulePasses);
-    
     LLVMPassManagerBuilderPopulateFunctionPassManager(passBuilder,
                                                       functionPasses);
     LLVMPassManagerBuilderPopulateModulePassManager(passBuilder, modulePasses);
Index: llvm/trunk/bindings/go/llvm/target.go
===================================================================
--- llvm/trunk/bindings/go/llvm/target.go
+++ llvm/trunk/bindings/go/llvm/target.go
@@ -121,13 +121,6 @@
 	return
 }
 
-// Adds target data information to a pass manager. This does not take ownership
-// of the target data.
-// See the method llvm::PassManagerBase::add.
-func (pm PassManager) Add(td TargetData) {
-	C.LLVMAddTargetData(td.C, pm.C)
-}
-
 // Converts target data to a target layout string. The string must be disposed
 // with LLVMDisposeMessage.
 // See the constructor llvm::TargetData::TargetData.
Index: llvm/trunk/bindings/go/llvm/executionengine_test.go
===================================================================
--- llvm/trunk/bindings/go/llvm/executionengine_test.go
+++ llvm/trunk/bindings/go/llvm/executionengine_test.go
@@ -81,7 +81,6 @@
 	pass := NewPassManager()
 	defer pass.Dispose()
 
-	pass.Add(engine.TargetData())
 	pass.AddConstantPropagationPass()
 	pass.AddInstructionCombiningPass()
 	pass.AddPromoteMemoryToRegisterPass()
Index: llvm/trunk/docs/ReleaseNotes.rst
===================================================================
--- llvm/trunk/docs/ReleaseNotes.rst
+++ llvm/trunk/docs/ReleaseNotes.rst
@@ -42,6 +42,8 @@
 
 * The C API function LLVMLinkModules has been removed.
 
+* The C API function LLVMAddTargetData has been removed.
+
 .. NOTE
    For small 1-3 sentence descriptions, just add an entry at the end of
    this list. If your description won't fit comfortably in one bullet


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D17282.48036.patch
Type: text/x-patch
Size: 3776 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160216/6b9d112a/attachment.bin>


More information about the llvm-commits mailing list