[PATCH] D17139: [test-suite][mips] Fix MIPS related conditions in the CMakeLists.txt

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 15 15:08:45 PST 2016


dsanders added a comment.

My thinking was that they're both substring matches and the shorter version is a bit simpler. Having dug into it a bit more it looks like MIPSARCH has just been transcribed from the Makefile where it was an arbitrary string provided by one of our internal buildbots. 'mips16' is the only MIPS16-related value I can see.

In light of that, we probably shouldn't require the user to provide it and instead figure it out from the CFLAGS/CXXFLAGS by checking for __mips16 with check_symbol_exists(). Similarly for the other checks on MIPSARCH.


Repository:
  rL LLVM

http://reviews.llvm.org/D17139





More information about the llvm-commits mailing list