[PATCH] D15781: [compiler-rt] Add support for ARM EHABI to gcc_personality_v0.

[Saleem Abdulrasool via llvm-commits]

compnerd added inline comments.

================
Comment at: lib/builtins/gcc_personality_v0.c:148
@@ +147,3 @@
+        return _URC_FAILURE;
+    }
+    return _URC_CONTINUE_UNWIND;
----------------
The braces are unnecessary.  Did you run this through clang-format?

================
Comment at: lib/builtins/gcc_personality_v0.c:184
@@ +183,3 @@
+#if USING_ARM_EHABI
+    if ( (state & _US_ACTION_MASK) == _US_VIRTUAL_UNWIND_FRAME )
+        return continueUnwind(exceptionObject, context);
----------------
Shouldn't this be:

    if ((state & _US_ACTION_MASK) != _US_UNWIND_FRAME_STARTING)


================
Comment at: lib/builtins/gcc_personality_v0.c:198
@@ -165,2 +197,3 @@
         return _URC_CONTINUE_UNWIND;
+#endif
 
----------------
I think we should move the `USING_ARM_EABI` check into the continueUnwind and have it do the right thing so we can avoid the check here and below.


http://reviews.llvm.org/D15781