[PATCH] D16920: [AMDGPU] Rename $dst operand to $vdst for VOP instructions.

[Matt Arsenault via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with a few nits


================
Comment at: lib/Target/AMDGPU/SIInstrInfo.td:1189
@@ -1188,3 +1188,3 @@
 // by getAsm64.
-class getAsm32 <bit HasDst, int NumSrcArgs> {
-  string dst = "$dst";
+class getAsm32 <bit HasDst, ValueType DstVT, int NumSrcArgs> {
+  string dst = !if(!eq(DstVT.Size, 1), "$sdst", "$vdst"); // use $sdst for VOPC
----------------
This would be less intrusive if DstVT was the last argument defaulting to i32

================
Comment at: lib/Target/AMDGPU/SIInstrInfo.td:1348
@@ -1344,2 +1347,3 @@
   let HasDst32 = 0;
+  let Outs64 =  (outs DstRC:$sdst);
 }
----------------
Extra space after =

================
Comment at: lib/Target/AMDGPU/VIInstrFormats.td:135
@@ +134,3 @@
+
+  let Inst{7-0}   = vdst;
+}
----------------
Extra spaces before =

================
Comment at: lib/Target/AMDGPU/VIInstrFormats.td:143
@@ +142,3 @@
+
+  let Inst{7-0}   = sdst;
+}
----------------
Ditto


http://reviews.llvm.org/D16920