[PATCH] D17241: [Refactor] Move isl_ctx into Scop.

Mon Feb 15 08:01:13 PST 2016

etherzhhb added a comment.

Actually we free ScopInfo before other scop analyses:
[2016-02-15 16:19:24.577937000] 0x380e7c0 Freeing Pass 'Polly - Create polyhedral description of Scops' on Region 'for.cond => for.end8'...
[2016-02-15 16:19:24.578081000] 0x380e7c0 Freeing Pass 'Polly - Generate an AST from the SCoP (isl)' on Region 'for.cond => for.end8'...
[2016-02-15 16:19:24.578174000] 0x380e7c0 Freeing Pass 'Polly - Calculate dependences' on Region 'for.cond => for.end8'...

In http://reviews.llvm.org/D17241#352782, @etherzhhb wrote:

> In http://reviews.llvm.org/D17241#352759, @llvm-commits wrote:
>
> > > And if  ScopInfo, DependencyInfo, IslAst are not free in order, it become a total mess ....
> >
> >
> > The pass manager should free IslAst, DependencyInfo, ... __before__ ScopInfo
> >  because they have a dependence on the ScopInfo results. Am I wrong?
>
>
> Sorry I am not precise enough. It should be Scop (the result of ScopInfo), Dependences (the result of DependenceInfo) and IslAst (the result of IslAstInfo).
>
> Let me do some experiments to confirm the order with the debug-pass option.

Repository:
  rL LLVM

http://reviews.llvm.org/D17241