[PATCH] D17228: Fix bug in SanitizerCommon.StartSubprocessTest causing flaky behavior.

Zia Ansari via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 14 21:16:13 PST 2016


This revision was automatically updated to reflect the committed changes.
Closed by commit rL260876: Fixed non-NULL terminating array bug in SanitizerCommon.StartSubprocessTest… (authored by zansari).

Changed prior to commit:
  http://reviews.llvm.org/D17228?vs=47873&id=47943#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D17228

Files:
  compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_linux_test.cc

Index: compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_linux_test.cc
===================================================================
--- compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_linux_test.cc
+++ compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_linux_test.cc
@@ -271,7 +271,7 @@
 #else
   const char *shell = "/bin/sh";
 #endif
-  const char *argv[] = {shell, "-c", "echo -n 'hello'"};
+  const char *argv[] = {shell, "-c", "echo -n 'hello'", (char *)NULL};
   int pid = StartSubprocess(shell, argv,
                             /* stdin */ kInvalidFd, /* stdout */ pipe_fds[1]);
   ASSERT_GT(pid, 0);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D17228.47943.patch
Type: text/x-patch
Size: 633 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160215/40b0cc1e/attachment.bin>


More information about the llvm-commits mailing list