[PATCH] D17115: Define the ThinLTO Pipeline

[Mehdi AMINI via llvm-commits]

joker.eph added inline comments.

================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:710
@@ -684,1 +709,3 @@
 
+void PassManagerBuilder::populateThinLTOPassManager(
+    legacy::PassManagerBase &PM) {
----------------
tejohnson wrote:
> Ok, for now I suppose you can just set the FunctionIndex to null before invoking this.
> 
> I haven't done a full comparison between the LTO pipeline and the new ThinLTO pipeline here, is there anything else done in the LTO pipeline that is worth adding to this, or is it all covered by the module passes? Looks like it from my quick scan but I didn't compare extensively...
> 
> Also, after this goes in clang should be changed to invoke this instead of populateLTOPassManager in EmitAssemblyHelper::CreatePasses when we have a function index. And I can change my gold threads patch for ThinLTO (D15390) to do the same for ThinLTO compiles.
I tend to be data driven, so we're looking at benchmarks and tracking issues right now, but this is a good starting point.




http://reviews.llvm.org/D17115