[compiler-rt] r260669 - [msan+tsan] Bring back the tests that disappeared after r260230 and r259512.

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 14 02:05:17 PST 2016


Hi,

Is it ok to merge the tsan part of this to the 3.8 release?
________________________________________
From: llvm-commits [llvm-commits-bounces at lists.llvm.org] on behalf of Daniel Sanders via llvm-commits [llvm-commits at lists.llvm.org]
Sent: 12 February 2016 10:35
To: llvm-commits at lists.llvm.org
Subject: [compiler-rt] r260669 - [msan+tsan] Bring back the tests that disappeared after r260230 and r259512.

Author: dsanders
Date: Fri Feb 12 04:35:53 2016
New Revision: 260669

URL: http://llvm.org/viewvc/llvm-project?rev=260669&view=rev
Log:
[msan+tsan] Bring back the tests that disappeared after r260230 and r259512.

The lit test-suite containing the unit tests needs to be explicitly specified
as an argument to lit.py since it is no longer discovered when the other tests
are run (because they are one directory deeper).

dfsan, lsan, and sanitizer_common don't show the same problem.


Modified:
    compiler-rt/trunk/test/msan/CMakeLists.txt
    compiler-rt/trunk/test/tsan/CMakeLists.txt

Modified: compiler-rt/trunk/test/msan/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/msan/CMakeLists.txt?rev=260669&r1=260668&r2=260669&view=diff
==============================================================================
--- compiler-rt/trunk/test/msan/CMakeLists.txt (original)
+++ compiler-rt/trunk/test/msan/CMakeLists.txt Fri Feb 12 04:35:53 2016
@@ -41,7 +41,7 @@ if(COMPILER_RT_INCLUDE_TESTS AND COMPILE
 endif()

 add_lit_testsuite(check-msan "Running the MemorySanitizer tests"
-  ${MSAN_TESTSUITES}
+  ${MSAN_TESTSUITES} ${CMAKE_CURRENT_BINARY_DIR}/Unit
   DEPENDS ${MSAN_TEST_DEPS}
   )
 set_target_properties(check-msan PROPERTIES FOLDER "MSan tests")

Modified: compiler-rt/trunk/test/tsan/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/tsan/CMakeLists.txt?rev=260669&r1=260668&r2=260669&view=diff
==============================================================================
--- compiler-rt/trunk/test/tsan/CMakeLists.txt (original)
+++ compiler-rt/trunk/test/tsan/CMakeLists.txt Fri Feb 12 04:35:53 2016
@@ -50,6 +50,6 @@ if(COMPILER_RT_INCLUDE_TESTS)
 endif()

 add_lit_testsuite(check-tsan "Running ThreadSanitizer tests"
-  ${TSAN_TESTSUITES}
+  ${TSAN_TESTSUITES} ${CMAKE_CURRENT_BINARY_DIR}/Unit
   DEPENDS ${TSAN_TEST_DEPS})
 set_target_properties(check-tsan PROPERTIES FOLDER "TSan tests")


_______________________________________________
llvm-commits mailing list
llvm-commits at lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list