[PATCH] D17238: [Refactor] Eliminate the global variable "InsnToMemAcc".

[Hongbin Zheng via llvm-commits]

etherzhhb added a comment.




================
Comment at: include/polly/ScopDetection.h:225
@@ +224,3 @@
+  ///        instructions.
+  mutable MapInsnToMemAcc InsnToMemAcc;
+
----------------
jdoerfert wrote:
> Why mutable? If you try to modify it but the "const" state of almost all methods in the ScopDetection is blocking you, put the InstToMemAcc into the DetectionContext, that is what we always did and what makes it clear it belongs to this detection context.
Ok

================
Comment at: include/polly/ScopDetection.h:523
@@ +522,3 @@
+  ///        function
+  MapInsnToMemAcc &getInsnToMemAccMap() const { return InsnToMemAcc; }
+
----------------
jdoerfert wrote:
> In methods like "getBoxedLoops" you can easily see how you can access the "correct" InstToMemAcc once it is moved to the DetectionContext.
ok


Repository:
  rL LLVM

http://reviews.llvm.org/D17238