[PATCH] D16756: Added SKL and CNL processors and features to Clang

[David Kreitzer via llvm-commits]

DavidKreitzer added inline comments.

================
Comment at: lib/Basic/Targets.cpp:3246
@@ +3245,3 @@
+    defineCPUMacros(Builder, "cnl");
+    break;
+  case CK_SkylakeServer:
----------------
sanjoy wrote:
> Should these also be `"skylake"` and `"cannonlake"`?
Assuming that we keep them at all, they probably should be renamed. We are trying to get agreement from gcc on the exact spelling of all these pre-defined macros to avoid future headaches.

Elena, has there been any progress on that? I think that's the only thing holding up this patch.



Repository:
  rL LLVM

http://reviews.llvm.org/D16756