[llvm] r260808 - No need to make the subtarget feature bit enum a uint64_t. This was a leftover from when the feature bit enum contained masks instead of bit indices.

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 12 23:46:03 PST 2016


On Fri, Feb 12, 2016 at 10:03 PM, Craig Topper via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: ctopper
> Date: Sat Feb 13 00:03:29 2016
> New Revision: 260808
>
> URL: http://llvm.org/viewvc/llvm-project?rev=260808&view=rev
> Log:
> No need to make the subtarget feature bit enum a uint64_t. This was a
> leftover from when the feature bit enum contained masks instead of bit
> indices.
>
> Modified:
>     llvm/trunk/utils/TableGen/SubtargetEmitter.cpp
>
> Modified: llvm/trunk/utils/TableGen/SubtargetEmitter.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/SubtargetEmitter.cpp?rev=260808&r1=260807&r2=260808&view=diff
>
> ==============================================================================
> --- llvm/trunk/utils/TableGen/SubtargetEmitter.cpp (original)
> +++ llvm/trunk/utils/TableGen/SubtargetEmitter.cpp Sat Feb 13 00:03:29 2016
> @@ -127,7 +127,7 @@ void SubtargetEmitter::Enumeration(raw_o
>    OS << "namespace " << Target << " {\n";
>
>    // Open enumeration. Use a 64-bit underlying type.
>

Should this comment be updated?


> -  OS << "enum : uint64_t {\n";
> +  OS << "enum {\n";
>
>    // For each record
>    for (unsigned i = 0; i < N;) {
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160212/5493e8d4/attachment.html>


More information about the llvm-commits mailing list