[PATCH] D17229: [CodeGen] Document and use getConstant's splat-building feature.

Ahmed Bougacha via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 12 17:56:59 PST 2016


ab created this revision.
ab added subscribers: RKSimon, spatel, arsenm, llvm-commits.

As discussed in D17176, getConstant already supports splats; let's use it!

As I mention there, I do think that the name "getConstant" could be confusing. In practice I don't think it's a problem, with proper names and context. That's not ideal though, so perhaps we should add "getConstantVec" (or "getConstantSplat"?) versions of the 6 getConstant variants we already have?


http://reviews.llvm.org/D17229

Files:
  include/llvm/CodeGen/SelectionDAG.h
  lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp
  lib/Target/ARM/ARMISelLowering.cpp
  lib/Target/PowerPC/PPCISelLowering.cpp
  lib/Target/X86/X86ISelLowering.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D17229.47883.patch
Type: text/x-patch
Size: 17754 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160213/44d49fa1/attachment.bin>


More information about the llvm-commits mailing list