[PATCH] D17176: [CodeGen] Add getBuildVector and getSplatBuildVector helpers.

Ahmed Bougacha via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 12 17:39:13 PST 2016


ab added inline comments.

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:4539
@@ -4540,1 +4538,3 @@
+    return DAG.getNode(ISD::BUILD_VECTOR,
+        dl, ResultVT, makeArrayRef(Vec->op_begin() + IdxVal, ElemsPerChunk));
 
----------------
RKSimon wrote:
> Why not updated to DAG.getBuildVector?
Because the array is made of SDUse, not SDValues.

The formatting change betrays me undoing my macro when realizing that this didn't build anymore ;)


http://reviews.llvm.org/D17176





More information about the llvm-commits mailing list