[PATCH] Introduce llvm/ADT/OptionSet.h utility class

[Chris Lattner via llvm-commits]

On Feb 12, 2016, at 2:29 PM, Philip Reames <listmail at philipreames.com> wrote:
>> The code is 100% copyrighted by Apple.  The full history in the swift repo is here:
>> https://github.com/apple/swift/commits/master/include/swift/Basic/OptionSet.h <https://github.com/apple/swift/commits/master/include/swift/Basic/OptionSet.h>
>> 
>> There are two trivial patches by non-apple contributors.  Both are both single line patches that adjust comments (one is the first line of the file, one is the copyright date):
>> https://github.com/apple/swift/commit/1339b5403bbaf6205abb2bfdf7fabadef1aacc70#diff-1e8f8df8addd9510deea20d4bea2eda2 <https://github.com/apple/swift/commit/1339b5403bbaf6205abb2bfdf7fabadef1aacc70#diff-1e8f8df8addd9510deea20d4bea2eda2>
>> https://github.com/apple/swift/commit/e3a4147ac94e55fcab1d14e949f572b53d9eb638#diff-1e8f8df8addd9510deea20d4bea2eda2 <https://github.com/apple/swift/commit/e3a4147ac94e55fcab1d14e949f572b53d9eb638#diff-1e8f8df8addd9510deea20d4bea2eda2>
>> 
>> That said, both of those patches are irrelevant to the discussion, because Argyrios removed the swift header and           replaced it with the LLVM header when he checked it in.
> Just to be clear, you're saying that Apple owns the copyright on the entire file as posted for review and can thus relicense under the LLVM license?

Yes.

> If so, that would resolve the licensing concern.  In the future, let's make sure that gets mentioned in the review/commit thread to avoid confusion.

I can understand your concern, but for better or worse, we don’t ask llvm contributors to state the provenance of their code that they are posting.  If you’re asking for some new rule to be put in place, please specify what the rule is and what the rationale for that rule is.

> With that, we're back to "let's post a patch and get it reviewed" per the normal process.  

Exactly.

-Chris

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160212/5c4e41f9/attachment.html>