[PATCH] D15390: [ThinLTO] Launch importing backends in parallel threads from gold plugin
Mehdi AMINI via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 12 14:07:18 PST 2016
joker.eph added inline comments.
================
Comment at: tools/gold/gold-plugin.cpp:1019
@@ +1018,3 @@
+ raw_svector_ostream BCOS(BCs.back());
+ WriteBitcodeToFile(MPart.get(), BCOS);
+ });
----------------
pcc wrote:
> I don't think thread pools are necessary for split code gen, as we can already perfectly assign the right amount of work to individual threads. Also, this implementation loses the pipelining feature from the original code (i.e. worker threads can work on codegen'ing while the main thread is still splitting). I would prefer you to use the existing implementation in `llvm/CodeGen/ParallelCG.h`.
The thread that is doing the splitting can issue other jobs to the thread pool, providing the desired pipeline.
Just fuse the loop body below within the lambda...
http://reviews.llvm.org/D15390
More information about the llvm-commits
mailing list