[llvm] r260529 - Drop the hidden visibility from DebugHandlerBase for now.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 12 13:36:04 PST 2016


On 12 February 2016 at 16:32, Benjamin Kramer <benny.kra at gmail.com> wrote:
> On Fri, Feb 12, 2016 at 7:12 PM, Rafael EspĂ­ndola
> <rafael.espindola at gmail.com> wrote:
>> On 11 February 2016 at 10:41, Benjamin Kramer via llvm-commits
>> <llvm-commits at lists.llvm.org> wrote:
>>> Author: d0k
>>> Date: Thu Feb 11 09:41:56 2016
>>> New Revision: 260529
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=260529&view=rev
>>> Log:
>>> Drop the hidden visibility from DebugHandlerBase for now.
>>>
>>> If a class has hidden visibility all derived classes and all classes
>>> that have it as a member must have hidden visibility too. That may
>>> be fixable here but requires changes to quite a lot of debug info
>>> classes.
>>>
>>> This is also one of the things that GCC enforces aggressively while
>>> clang ignores it, making testing more annoying than necessary.
>>
>> Can you open a bug with the case that gcc produces an error but we don't?
>
> No error, just warnings. We already have http://llvm.org/PR13009 for that :)

Oops, I have away from clang for too long I guess :-)

Thanks,
Rafael


More information about the llvm-commits mailing list