[PATCH] Introduce llvm/ADT/OptionSet.h utility class

[Chris Lattner via llvm-commits]

On Feb 12, 2016, at 1:19 PM, Chris Lattner <clattner at apple.com> wrote:
> 
> On Feb 12, 2016, at 1:08 PM, Chandler Carruth <chandlerc at gmail.com <mailto:chandlerc at gmail.com>> wrote:
>>> I got permission internally and contributed the header under the LLVM license, I don’t think that whether it originated from swift repo or not makes any difference here.
>>> If you could elaborate more on your concerns it would be helpful.
>>> 
>>> How do we know whether any other contributor to Swift authored some of the code in this file? Does Apple get copyright assignment for all Swift contributions? Only if Apple has copyright assignment for all contributions to Swift or only people from Apple have every contributed to this part of Swift is asking internally enough.
>>> 
>>> And since this is an open source project, it would seem polite (even if not necessary) to also ask the community rather than just asking internally. We don't all work at Apple. =/
> 
> The code is 100% copyrighted by Apple.  The full history in the swift repo is here:
> https://github.com/apple/swift/commits/master/include/swift/Basic/OptionSet.h <https://github.com/apple/swift/commits/master/include/swift/Basic/OptionSet.h>
> 
> There are two trivial patches by non-apple contributors.  Both are both single line patches that adjust comments (one is the first line of the file, one is the copyright date):
> https://github.com/apple/swift/commit/1339b5403bbaf6205abb2bfdf7fabadef1aacc70#diff-1e8f8df8addd9510deea20d4bea2eda2 <https://github.com/apple/swift/commit/1339b5403bbaf6205abb2bfdf7fabadef1aacc70#diff-1e8f8df8addd9510deea20d4bea2eda2>
> https://github.com/apple/swift/commit/e3a4147ac94e55fcab1d14e949f572b53d9eb638#diff-1e8f8df8addd9510deea20d4bea2eda2 <https://github.com/apple/swift/commit/e3a4147ac94e55fcab1d14e949f572b53d9eb638#diff-1e8f8df8addd9510deea20d4bea2eda2>
> 
> That said, both of those patches are irrelevant to the discussion, because Argyrios removed the swift header and replaced it with the LLVM header when he checked it in.

Incidentally and unrelatedly, the Swift repo has a bunch of other generally useful “ADT like” support stuff:
https://github.com/apple/swift/tree/master/include/swift/Basic

If folks are interested in seeing any parts of it go up to LLVM, I’d love to see that happen.

-Chris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160212/869d6470/attachment.html>