[PATCH] D17207: [ADT] Fix PointerEmbeddedInt when the underlying type is uintptr_t.

[Jordan Rose via llvm-commits]

jordan_rose added inline comments.

================
Comment at: include/llvm/ADT/PointerEmbeddedInt.h:48-50
@@ -44,1 +47,5 @@
 
+  enum RawValue_t {
+    RawValue
+  };
+
----------------
chandlerc wrote:
> Rather than this, use an empty struct? That's a better tag type as it is literally not passed in the ABI, just changes the overload resolution at compile time.
> 
> The _t suffix is also not terribly common in LLVM. I'd go with 'RawValueTag' personally.
Good point. I was trying to avoid the weirdness of creating a nonce value, but that's doable with a constexpr member.


Repository:
  rL LLVM

http://reviews.llvm.org/D17207