[PATCH] D17159: AMDGPU/SI: Add instruction defs for VOP1 DPP instructions
Tom Stellard via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 12 12:08:16 PST 2016
tstellarAMD marked an inline comment as done.
================
Comment at: lib/Target/AMDGPU/VIInstrFormats.td:190
@@ +189,3 @@
+ let Inst{16-9} = op;
+ let Inst{24-17} = dst;
+ let Inst{31-25} = 0x3f; //encoding
----------------
arsenm wrote:
> Why isn't this set in the base class?
I wanted to have a clear separation between the low and high bits. Also, we won't be able to have it in the base class when we add VOPC_DPP.
http://reviews.llvm.org/D17159
More information about the llvm-commits
mailing list