[PATCH] Introduce llvm/ADT/OptionSet.h utility class

Fri Feb 12 11:52:30 PST 2016

> On Feb 12, 2016, at 11:38 AM, Chandler Carruth <chandlerc at gmail.com> wrote:
> 
> On Fri, Feb 12, 2016 at 11:32 AM Argyrios Kyrtzidis <kyrtzidis at apple.com <mailto:kyrtzidis at apple.com>> wrote:
>> On Feb 12, 2016, at 11:23 AM, Philip Reames <listmail at philipreames.com <mailto:listmail at philipreames.com>> wrote:
>> 
>> Er, if this didn't get reviewed, please revert it.  This is not merely poor form, but unacceptable for non-trivial changes in areas for which you are not a regular contributor.  
> 
> + Chandler, who is listed as ADT owner. I’d like to get his opinion if this needs to be reverted.
> 
> It isn't up to the owner of ADT to decide whether this needs to be reverted. All I can do in that capacity is help you find a reviewer.
> 
> The community as a whole gets to say whether it needs to be reverted, and I think Philip has made a clear point here (which I completely agree with) and so I think you should probably revert. =]

Ok, reverted in r260714.

> 
>  
> 
>> 
>> In particular, moving code between the swift repo and the LLVM repo is not necessarily OK.  At minimum, there needs to be some discussion on llvm-dev of the licensing and implications.  Specifically, with the possible relicensing being discussed, adding a bunch of unknown external authors (even if the current license is compatible) might not be a good idea.
> 
> I got permission internally and contributed the header under the LLVM license, I don’t think that whether it originated from swift repo or not makes any difference here.
> If you could elaborate more on your concerns it would be helpful.
> 
> How do we know whether any other contributor to Swift authored some of the code in this file? Does Apple get copyright assignment for all Swift contributions? Only if Apple has copyright assignment for all contributions to Swift or only people from Apple have every contributed to this part of Swift is asking internally enough.
> 
> And since this is an open source project, it would seem polite (even if not necessary) to also ask the community rather than just asking internally. We don't all work at Apple. =/
>  
> 
>> 
>> As such, please revert.
>> 
>> Philip
>> 
>> On 02/11/2016 11:33 PM, Argyrios Kyrtzidis via llvm-commits wrote:
>>> Sorry about that, I became a bit concerned this was inconsequential enough that people would not really care to provide feedback.
>>> 
>>>> On Feb 11, 2016, at 11:26 PM, David Blaikie < <mailto:dblaikie at gmail.com>dblaikie at gmail.com <mailto:dblaikie at gmail.com>> wrote:
>>>> 
>>>> It's generally considered poor form to commit something without review, after asking for it... 
>>>> 
>>>> On Thu, Feb 11, 2016 at 6:54 PM, Argyrios Kyrtzidis via llvm-commits <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
>>>> I’ve took the liberty of committing in r260652, since this is general goodness and doesn’t affect existing code.
>>>> 
>>>> > On Feb 10, 2016, at 9:23 PM, Argyrios Kyrtzidis <kyrtzidis at apple.com <mailto:kyrtzidis at apple.com>> wrote:
>>>> >
>>>> > Hi all,
>>>> >
>>>> > The attached patch introduces ‘OptionSet’ in llvm/ADT headers, which is a utility class that makes it convenient to work with enumerators representing bit options.
>>>> >
>>>> > We have found it useful in the swift repo ( <https://github.com/apple/swift/blob/master/include/swift/Basic/OptionSet.h>https://github.com/apple/swift/blob/master/include/swift/Basic/OptionSet.h <https://github.com/apple/swift/blob/master/include/swift/Basic/OptionSet.h>) and I think it will be useful to other llvm projects as well.
>>>> >
>>>> > Let me know if you think it is ok to commit in llvm repo.
>>>> >
>>>> > <optionset.patch>
>>>> 
>>>> _______________________________________________
>>>> llvm-commits mailing list
>>>> llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
>>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits>
>>>> 
>>> 
>>> 
>>> 
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits>
>> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160212/1255c524/attachment.html>