[llvm] r260439 - [LVI] Handle constants defensively

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 12 11:32:25 PST 2016



On 02/11/2016 02:19 PM, Renato Golin wrote:
> On 10 February 2016 at 22:29, Philip Reames via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>> FYI, this change was causing clang test failures due to clang tests which
>> were checking particular IR and caught the more precise getValueAt results.
>>
>> Hopefully, the clang builds are fixed w/260451.  I ended up fixing that not
>> by changing the clang tests, but by not placing nonnull attributes on
>> parameters which are simply constants.  Doing so doesn't gain us any extra
>> information and is just a waste of compile time.
> Hi Philip,
>
> After a bisect, it seems that this is the cause of:
>
> http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-a15-full-sh/builds/3160
>
> http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full
>
> thought the last seem to be fixed.
>
> I'll keep an eye for the rest and will let you know.
>
> cheers,
> --renato
Are you still seeing any failures here?  I've been watching the bots and 
don't see any remaining.  If you do, I'd like to know.  :)

Philip



More information about the llvm-commits mailing list