[PATCH] Introduce llvm/ADT/OptionSet.h utility class

[Philip Reames via llvm-commits]

Er, if this didn't get reviewed, please revert it.  This is not merely 
poor form, but unacceptable for non-trivial changes in areas for which 
you are not a regular contributor.

In particular, moving code between the swift repo and the LLVM repo is 
not necessarily OK.  At minimum, there needs to be some discussion on 
llvm-dev of the licensing and implications. Specifically, with the 
possible relicensing being discussed, adding a bunch of unknown external 
authors (even if the current license is compatible) might not be a good 
idea.

As such, please revert.

Philip

On 02/11/2016 11:33 PM, Argyrios Kyrtzidis via llvm-commits wrote:
> Sorry about that, I became a bit concerned this was inconsequential 
> enough that people would not really care to provide feedback.
>
>> On Feb 11, 2016, at 11:26 PM, David Blaikie <dblaikie at gmail.com 
>> <mailto:dblaikie at gmail.com>> wrote:
>>
>> It's generally considered poor form to commit something without 
>> review, after asking for it...
>>
>> On Thu, Feb 11, 2016 at 6:54 PM, Argyrios Kyrtzidis via llvm-commits 
>> <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
>>
>>     I’ve took the liberty of committing in r260652, since this is
>>     general goodness and doesn’t affect existing code.
>>
>>     > On Feb 10, 2016, at 9:23 PM, Argyrios Kyrtzidis
>>     <kyrtzidis at apple.com <mailto:kyrtzidis at apple.com>> wrote:
>>     >
>>     > Hi all,
>>     >
>>     > The attached patch introduces ‘OptionSet’ in llvm/ADT headers,
>>     which is a utility class that makes it convenient to work with
>>     enumerators representing bit options.
>>     >
>>     > We have found it useful in the swift repo
>>     (https://github.com/apple/swift/blob/master/include/swift/Basic/OptionSet.h)
>>     and I think it will be useful to other llvm projects as well.
>>     >
>>     > Let me know if you think it is ok to commit in llvm repo.
>>     >
>>     > <optionset.patch>
>>
>>     _______________________________________________
>>     llvm-commits mailing list
>>     llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
>>     http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>>
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160212/b5eb3fa4/attachment.html>