[PATCH] D17196: [test-suite] Use cmake `find_package` to search zLib for ClamAV test case
Matthias Braun via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 12 10:57:43 PST 2016
MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.
We really should avoid external dependencies in benchmarks in the long term. But this is indeed the right way to deal with that benchmark today. Some comments:
- cmake also offers https://cmake.org/cmake/help/v3.0/module/FindZLIB.html how does that compare to find_package(ZLIB)?
- I'd just disable the whole benchmark if libz couldn't be found instead of trying anyway.
In any way this is simple enough to just commit (there's always post-commit review).
Repository:
rL LLVM
http://reviews.llvm.org/D17196
More information about the llvm-commits
mailing list