[PATCH] D16888: [mips] Addition of a third operand to the instructions [d]div, [d]divu

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 12 09:27:56 PST 2016


dsanders requested changes to this revision.
dsanders added a comment.
This revision now requires changes to proceed.

Could you make the summary more like a commit message?

I don't see any code to handle things like 'ddiv $zero, $4, $5' but it's possible that the real instruction has priority over the macro because $zero is more specific. Could you add tests for 'ddiv $zero, $4, $5' and check that it only expands to a single 'ddiv $zero, $4, $5' instruction? Similarly for ddivu/dmod/dmodu


http://reviews.llvm.org/D16888





More information about the llvm-commits mailing list