[PATCH] D17181: [X86] Don't turn (c?-v:v) into (c?-v:0) by blindly using PSIGN.

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 12 09:09:35 PST 2016


> On Feb 11, 2016, at 6:12 PM, Ahmed Bougacha <ahmed.bougacha at gmail.com> wrote:
> 
> ab added inline comments.
> 
> ================
> Comment at: test/CodeGen/X86/vec-sign.ll:7
> @@ -6,2 +6,3 @@
> ; CHECK:       # BB#0: # %entry
> +; CHECK-NEXT:    por {{.*}}(%rip), %xmm1
> ; CHECK-NEXT:    psignd %xmm1, %xmm0
> ----------------
> This isn't very helpful; I'll try to look into getting some CP verbose printing.

And/or you could match the CP with the value you expect and check we are loading form the right address.

> 
> 
> http://reviews.llvm.org/D17181
> 
> 
> 



More information about the llvm-commits mailing list