[PATCH] D17200: [mips] Implemented the .hword directive.

[Daniel Sanders via llvm-commits]

dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.

LGTM with the missing zeros and a commit message correction.

> ... as needing to point to the symbol and not the section.


It's the other way around. needsRelocateWithSymbol() is returning false (it takes the fallthrough path) which means it doesn't need the symbol and can rewrite it in terms of the section base.


================
Comment at: lib/Target/Mips/MCTargetDesc/MipsELFObjectWriter.cpp:419
@@ -417,3 +418,3 @@
       return true;
     // falltrough
   case ELF::R_MIPS_26:
----------------
Could you fix this typo while you're there?

================
Comment at: test/MC/Mips/mips-data-directives.s:20
@@ -18,2 +19,3 @@
+# CHECK-OBJ:      0000: DEADC0DE DEADC0DE DEADBEEF C0DE0000
 # CHECK-OBJ:      0010: 00000000 00000000
 # CHECK-OBJ:    )
----------------
There should be more zeros here, it seems to be four bytes short.


http://reviews.llvm.org/D17200