[PATCH] D17199: [mips] Made the .pdr section not allocatable.

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 12 07:07:23 PST 2016


dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.

LGTM with a couple tweaks to the commit message.

> [mips] Made the .pdr section not allocatable.

>  This section is used for debug information and has no need to be

>  allocatable. This also causes errors when compiling the Linux kernel.


We should probably mention SHF_ALLOC on the first subject line.

Could you explain what kind of errors it fixes? It should be enough to mention eliminating relocations in a VDSO and that we now emit the same flags as GAS.


http://reviews.llvm.org/D17199





More information about the llvm-commits mailing list